fix: do not attempt to reload base64 encoded urls #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Apr 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 67.08% 65.11% -1.98%
==========================================
Files 4 4
Lines 395 407 +12
Branches 77 82 +5
==========================================
Hits 265 265
- Misses 111 118 +7
- Partials 19 24 +5
Continue to review full report at Codecov.
|
|
For tests, I wanted to make some additional changes too, like setting up a new folder for some specific unit tests and get the manual test directory running. Because I have limited time this weekend, I'm not sure I'll be able to set those parts up. Today or tomorrow |
using something similar to whats found in loader-utils
alexander-akait
approved these changes
Apr 13, 2019
|
released this via https://github.com/faceyspacey/extract-css-chunks-webpack-plugin as a precaution :) |
|
@ScriptedAlchemy can you remove draft? |
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
No not try and reload non-URL based
<link>tagsexample:
<link rel="shortcut icon" href="data:;base64,=">Breaking Changes
Additional Info
fixs #377