chore(defaults): update #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
chore-update-defaults
branch
2 times, most recently
from
5c690cc
to
d2bac15
Compare
|
/cc @ScriptedAlchemy it is last PR before release with |
alexander-akait
force-pushed
the
chore-update-defaults
branch
from
d2bac15
to
1d145bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=========================================
Coverage ? 67.08%
=========================================
Files ? 4
Lines ? 395
Branches ? 77
=========================================
Hits ? 265
Misses ? 111
Partials ? 19
Continue to review full report at Codecov.
|
|
Reading over this PR now 👍 thanks for the mention |
|
|
||
| This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764 | ||
| Migration: see webpack/webpack#5225 | ||
|
|
||
| ``` | ||
|
|
||
| ## Testing Your Pull Request |
|
Looks good to me, great update! |
ScriptedAlchemy
previously approved these changes
Apr 9, 2019
alexander-akait
force-pushed
the
chore-update-defaults
branch
from
1d145bf
to
e028ed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
update defaults
Breaking Changes
no
Additional Info
no