allow additionalData to be async #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful if you want to use `loaderContext.resolve` to get additional data through the standard webpack mechanisms.
|
|
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 4 4
Lines 116 116
Branches 25 25
=======================================
Hits 113 113
Misses 3 3
Continue to review full report at Codecov.
|
|
Please accept CLA |
|
Signed |
|
Release will be tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This allows the result of
additionalDatato be a Promise.This is especially useful if you want to use
loaderContext.resolveto get additional data through the standard webpack mechanisms.Breaking Changes
none
Additional Info
n/a