Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): handle scenario test rejection #473

Merged
merged 1 commit into from Jan 30, 2021
Merged

fix(test): handle scenario test rejection #473

merged 1 commit into from Jan 30, 2021

Conversation

codymikol
Copy link
Owner

in newer versions of node, the promise
will never resolve if errors aren't
specifically handled. This can cause
tests to hang indefinitely.

Fixes N/A

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This prevents integration test failures from hanging indefinitely.

Breaking Changes

N/A

Additional Info

N/A

in newer versions of node, the promise
will never resolve if errors aren't
specifically handled. This can cause
tests to hang indefinitely.

Fixes N/A
@codymikol codymikol merged commit 8ad09d1 into codymikol:next Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants