Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma-webpack): don't error when webpackMiddleware config not provided #418

Merged
merged 1 commit into from Jun 8, 2019
Merged

fix(karma-webpack): don't error when webpackMiddleware config not provided #418

merged 1 commit into from Jun 8, 2019

Conversation

caseyWebb
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Error is thrown if no webpackMiddleware. You can see here the change that makes the CI pass again.

Breaking Changes

N/A

Additional Info

Regression introduced in 4.0.0

@jsf-clabot
Copy link

jsf-clabot commented Jun 7, 2019

CLA assistant check
All committers have signed the CLA.

@ryanclark
Copy link
Collaborator

ryanclark commented Jun 7, 2019

Perfect thanks!

@ryanclark ryanclark changed the title fix: don't error when webpackMiddleware config not provided' fix(karma-webpack): don't error when webpackMiddleware config not provided Jun 7, 2019
@ryanclark
Copy link
Collaborator

Seems to be stuck on the CLA check, @evilebottnawi any ideas?

@alexander-akait
Copy link
Collaborator

Sometimes it is buggy, just reopen issue

@ryanclark
Copy link
Collaborator

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants