fix(karma-webpack): Override output.filename with '[name].js'
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thijstriemstra: this pull request should fix your issue |
|
thanks for the ping @matthieu-foucault, can i install and test this PR using npm? |
Yes, using |
|
works: "karma-webpack@4.0.0-beta.0" thanks @matthieu-foucault |
thijstriemstra
approved these changes
Dec 9, 2018
matthieu-foucault
changed the title
output.filename with '[name].js'
|
@matthieu-foucault can this be released as a new RC? |
|
@thijstriemstra Done! Sorry for the delay |
|
thanks. for some reason it doesn't allow me to install rc.6 And |
|
It does appear in npmjs though (under the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
If there are multiple tests, and the webpack configuration has a static
output.filename, e.g.'bundle.js', all entry points will be emitted to the same bundle. Karma will output errors, andkarma-webpackwill ultimately fail as test files will not have any corresponding output file.