Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

fix(index): merge input and instrumented sourcemaps #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Oct 8, 2018

Based on the work by @adamburgess in #73 (comment).

Added a minimal update to work with the latest webpack (used in CI tests), updated a dependency with a security issue,, fixed a test, and added a fix for the sourcemaps file names.

Type

  • Bug

Issues

SemVer

  • Patch

Based on the work by @adamburgess in webpack-contrib#73 (comment).

Added Webpack 3 tests and a fix for the sourcemaps file names

Fix webpack-contrib#73
Node 4.8 jobs were removed because Webpack 4 does not support it.
Previous version showed a security warning for lodash on `npm run security`.
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #87 into master will increase coverage by 1.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   92.30%   94.11%   +1.80%     
==========================================
  Files           2        2              
  Lines          13       17       +4     
  Branches        2        3       +1     
==========================================
+ Hits           12       16       +4     
  Misses          1        1              
Impacted Files Coverage Δ
src/index.js 93.75% <100.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5fedb...041bcaa. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title fix: output sourcemaps back to source fix(index): merge input and instrumented sourcemaps Oct 8, 2018
@filipesilva
Copy link
Contributor Author

Heya @michael-ciniawsky, any update on when this might be merged/released?

@L2jLiga
Copy link

L2jLiga commented Jun 4, 2019

@d3viant0ne, @michael-ciniawsky any updates on this?

@JamesMessinger
Copy link

I created a new npm package named coverage-istanbul-loader. It includes the fix mentioned above as well as other fixes and updated dependencies.

@L2jLiga
Copy link

L2jLiga commented Jun 8, 2019

Hey, @filipesilva,
Why to not to use coverage-instanbul-loader?
In my point of vision it's great way to get code coverage. Either way Angular pin all dependencies.

(just I'm happened with broken test after migration to Angular 8 and sourcemap is really broken :( )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemaps not tracing back to the source
4 participants