Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

useRelativePath broken after update from 1.1.6 to 1.1.9 #257

Closed
lukaszsamson opened this issue Feb 26, 2018 · 11 comments
Closed

useRelativePath broken after update from 1.1.6 to 1.1.9 #257

lukaszsamson opened this issue Feb 26, 2018 · 11 comments

Comments

@lukaszsamson
Copy link

With the following options

options: {
              emitFile: false,
              name: '[name].[ext]',
              publicPath: 'assets/',
              useRelativePath: true
            }

and requiring img/path/to/file.png

In 1.1.6 the resulting URL is correct
assets/img/path/to/file.png
In 1.1.9 its
assets/file.png

@alexander-akait
Copy link
Member

@lukaszsamson can you create minimum reproducible test repo?

@lukaszsamson
Copy link
Author

I don't have a minimum repro, but I tested it a bit more and the regression was introduced in 1.1.8

@alexander-akait
Copy link
Member

@lukaszsamson without test repo it is hard to indicate problem place

@kernle32dll
Copy link

kernle32dll commented Feb 26, 2018

@lukaszsamson maybe a cause of #246? At least I stumbled across this yesterday and it seems oddly similar to your problem.

@alexander-akait
Copy link
Member

@kernle32dll right now we fix options how they should work, somebody can have invalid path configuration using bugs

@zemadz
Copy link

zemadz commented Feb 27, 2018

I've created a minimum repo to demonstrate this issue: https://github.com/zemadz/file-loader-relative-path-minimum-repro

There are two branches:

  • master (with file-loader@1.1.8)
  • working (with file-loader@1.1.7)

Run npm run build and see the output at build/js/index.js or npm test to investigate the different behaviors.

@lukaszsamson
Copy link
Author

#260 does not fix the issue

@michael-ciniawsky
Copy link
Member

Released in v1.1.11 🎉

@ossinkine
Copy link

@lukaszsamson I've faced with the same issue. Since #260 does not fix the issue how did you fix this?

@alexander-akait
Copy link
Member

@ossinkine useRelativePath option was removed in major release

@lukaszsamson
Copy link
Author

@ossinkine I stopped using this plugin in my config

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants