Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Extract Text Plugin does not work in child compilations #389

Closed
jantimon opened this issue Feb 2, 2017 · 12 comments
Closed

Extract Text Plugin does not work in child compilations #389

jantimon opened this issue Feb 2, 2017 · 12 comments

Comments

@jantimon
Copy link

jantimon commented Feb 2, 2017

From jantimon/html-webpack-plugin#579

The root problem is that the extract text plugin uses kind of a hack to communicate between loader and plugin. (See here https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/index.js#L216-L227 and here https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/loader.js#L26)
This hack works only in the main compilation however the html-webpack-plugin is using a child compilation.

This might add a feature request for the webpack core (easier communication between loaders and plugins)

@bebraw
Copy link
Contributor

bebraw commented Feb 2, 2017

This might add a feature request for the webpack core (easier communication between loaders and plugins)

This actually raises an interesting question. How to associate a loader or loaders with some specific plugin? Perhaps this means there needs to be a concept of identity. webpack core already uses something known as ident. If we went with that, you would pass ident field through a loader/plugin to associate them with each other (probably many to many should work too).

@michael-ciniawsky
Copy link
Member

Is there anything new happend recently in terms of webpack core ? How to start with this, any ideas?

@bebraw
Copy link
Contributor

bebraw commented Apr 23, 2017

Please ask Tobias for details.

@michael-ciniawsky
Copy link
Member

Maybe #483, but I didn't take a deeper look at it

@StevenDoesStuffs
Copy link

So it looks like this isn't getting fixed any time soon :/ because ultimately, #483 needs webpack/webpack#4704, which contains breaking changes and therefore will wait until webpack 3.

@StevenDoesStuffs
Copy link

Any progress besides that?

@joshwiens
Copy link
Member

Given this is dependent on multiple semver: Majors upstream as well as at least two in extract-text-webpack-plugin all of which require coordination, testing, beta builds => bug fixes the only thing anyone can tell you for certain about the time frame is it's certainly too early to be asking about.

@zfanning
Copy link

I saw that webpack 3 is out and was wondering about the current status of this issue?

@michael-ciniawsky
Copy link
Member

@zfanning #483 should have fixed it :)

@PTC-JoshuaMatthews
Copy link

I am still seeing this error using webpack 3.4.1.

@alexander-akait
Copy link
Member

@PTC-JoshuaMatthews can you create minimum reproducible test repo and create new issue

@sunilb0575
Copy link

my gem 'webpacker', '~> 3.2' version,
and I am stuck with this issue
https://stackoverflow.com/questions/55130980/error-extract-text-webpack-plugin-loader-is-used-without-the-corresponding-pl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants