Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): add webpack >= v4.0.0 (peerDependencies) #67

Merged
merged 1 commit into from Mar 7, 2018
Merged

fix(package): add webpack >= v4.0.0 (peerDependencies) #67

merged 1 commit into from Mar 7, 2018

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Mar 7, 2018

Supersedes #61

@alexander-akait alexander-akait added this to the 0.7.5 milestone Mar 7, 2018
@lencioni
Copy link
Contributor Author

lencioni commented Mar 7, 2018

Related work: webpack/webpack.js.org#1852

@michael-ciniawsky michael-ciniawsky changed the title Allow webpack v4 as a peerDependency fix(package): add webpack >= v4.0.0 (peerDependencies) Mar 7, 2018
michael-ciniawsky
michael-ciniawsky approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lencioni Thx

@michael-ciniawsky michael-ciniawsky merged commit daf39ea into webpack-contrib:master Mar 7, 2018
@alexander-akait
Copy link
Member

@michael-ciniawsky need patch release

@michael-ciniawsky
Copy link
Member

yep, yep I'm releasing all pending packages today, didn't have the time yesterday :)

@michael-ciniawsky
Copy link
Member

Released in v0.7.5 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 0.7.5 milestone Mar 9, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees
No one assigned
Labels
semver: Patch status: Approved type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lencioni @alexander-akait @michael-ciniawsky