fix: ensure userRequest stays unique (module.userRequest)
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
changed the title
userRequest stays unique (module.userRequest)
michael-ciniawsky
approved these changes
Nov 15, 2017
index.js
Outdated
| @@ -32,6 +32,7 @@ module.exports.pitch = function(remainingRequest) { | |||
| ); | |||
| this.cacheable && this.cacheable(); | |||
| if(!this.query) throw new Error("query parameter is missing"); | |||
| this._module.userRequest = this._module.userRequest + ' - exposed'; | |||
There was a problem hiding this comment.
Could you please add a comment marking this is as a workaround until module.libIdent() gets fixed ? :)
|
Please sign the CLA by closing and reopening the PR to trigger the CLA Bot again :) |
|
i signed it, see => https://cla.js.foundation/webpack-contrib/expose-loader?pullRequest=58 |
|
🤔 Is your email used by |
timse
force-pushed
the
fix-named-module-issue
branch
from
85dc4fc
to
273542c
Compare
|
that was it :P sorry |
alexander-akait
approved these changes
Nov 17, 2017
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
pr_action: Review
severity: 3 (broken)
status: Pending
labels
michael-ciniawsky
changed the title
userRequest stays unique (module.userRequest)userRequest stays unique (module.userRequest)
|
@timse Thx again 👍 |
|
np :) can we release that? |
|
Sry I can't cc @d3viant0ne :) |
|
@timse - Sorry, missed this one. I'll have it out in 20 minutes. |
joshwiens
pushed a commit
that referenced
this pull request
Nov 18, 2017
|
no worries @d3viant0ne and thnks for the release! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable ChangesThere is an issue using expose loader in combination with
webpack.NamedModulesPluginas the userRequest that is used by webpack to calculate the named modules id stays the same.See images below for explanation and fix:
Issueswebpack.config.jsfile not working with NamedModulesPlugin #55