Fix issue when multiple variables are exposed for the same request. #30
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit for more consistent hashes naively overwrote the entire request, assuming there weren't additional loaders to be run against the file. This modifies the changes to the request to only change the path to the imported file rather than changing the entire remainingRequest.
joshwiens
pushed a commit
that referenced
this pull request
Feb 14, 2017
…sed for the same request. (#30) The previous commit for more consistent hashes naively overwrote the entire request, assuming there weren't additional loaders to be run against the file. This modifies the changes to the request to only change the path to the imported file rather than changing the entire remainingRequest.
joshwiens
pushed a commit
that referenced
this pull request
Nov 18, 2017
…sed for the same request. (#30) The previous commit for more consistent hashes naively overwrote the entire request, assuming there weren't additional loaders to be run against the file. This modifies the changes to the request to only change the path to the imported file rather than changing the entire remainingRequest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit for more consistent hashes naively overwrote the
entire request, assuming there weren't additional loaders to be run
against the file. This modifies the changes to the request to only change
the path to the imported file rather than changing the entire
remainingRequest.
This is an attempt at fixing - #29
Also, I was worried that I might bork something else, so I created a repo here for quickly testing - https://github.com/gdborton/expose-loader-test