Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: drop node v12 #90

Merged
merged 2 commits into from May 17, 2022
Merged

build: drop node v12 #90

merged 2 commits into from May 17, 2022

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

alexander-akait
alexander-akait reviewed May 16, 2022
View reviewed changes
babel.config.js Outdated
@@ -10,7 +10,7 @@ module.exports = (api) => {
"@babel/preset-env",
{
targets: {
node: "12.13.0",
node: "14.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 14.15.0 (first LTS in v14) or 14.18.0 (ESM stabilization), but because we are still in commonjs (currently there are still many code in commonjs), so let's use 14.15.0 and postpone ESM migration on future (for the next major release)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. I will update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me everywhere when you update it 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait Done.

@snitin315 snitin315 force-pushed the drop-node-12 branch 2 times, most recently from 1df2505 to f98d587 Compare May 16, 2022 13:51
@codecov
Copy link

codecov bot commented May 16, 2022 •
edited

Codecov Report

Merging #90 (2157940) into master (11d071f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          124       124           
  Branches        50        50           
=========================================
  Hits           124       124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d071f...2157940. Read the comment docs.

@alexander-akait alexander-akait merged commit cbe0f2f into master May 17, 2022
@alexander-akait alexander-akait deleted the drop-node-12 branch May 17, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snitin315 @alexander-akait