From 8dad5bace0ddb3f9846187650254aba0366d4e6b Mon Sep 17 00:00:00 2001 From: Ricardo Gobbo de Souza Date: Thu, 4 Jul 2019 11:02:07 -0300 Subject: [PATCH] docs: update `gotchas` --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 25d1855..ad29281 100644 --- a/README.md +++ b/README.md @@ -298,7 +298,11 @@ module.exports = { ## Gotchas -### NoErrorsPlugin +### NoEmitOnErrorsPlugin for `webpack >= 4` + +`NoEmitOnErrorsPlugin` is now automatically enabled in webpack 4, when mode is either unset, or set to production. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`, except if `emitWarning` enabled. + +### NoErrorsPlugin for `webpack < 4` `NoErrorsPlugin` prevents webpack from outputting anything into a bundle. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`. @@ -316,7 +320,9 @@ See [#129](https://github.com/webpack-contrib/eslint-loader/issues/129). --- ## Changelog + [Changelog](CHANGELOG.md) ## License + [MIT](./LICENSE)