Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

please update minimist due to prototype pollution (CVE-2020-7598) #316

Closed
OZZlE opened this issue Mar 18, 2020 · 8 comments · Fixed by #317
Closed

please update minimist due to prototype pollution (CVE-2020-7598) #316

OZZlE opened this issue Mar 18, 2020 · 8 comments · Fixed by #317

Comments

@OZZlE
Copy link

OZZlE commented Mar 18, 2020

  • Operating System: Affects all
  • Node Version: v12.4.0
  • NPM Version: 6.9.0
  • webpack Version: 4.42.0
  • eslint-loader Version: 3.0.3

Expected Behavior

npm audit reports no vulnerabilities after installing this module

Actual Behavior

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ eslint-loader [dev]                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ eslint-loader > loader-fs-cache > mkdirp > minimist          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

How Do We Reproduce?

npm i eslint-loader@latest
npm audit

@neokeld
Copy link
Contributor

neokeld commented Mar 18, 2020

Related to this issue in loader-fs-cache : viankakrisna/loader-fs-cache#5

@neokeld
Copy link
Contributor

neokeld commented Mar 21, 2020

I've publish a fork of https://www.npmjs.com/package/loader-fs-cache (repo https://github.com/viankakrisna/loader-fs-cache) to fix this issue here : https://www.npmjs.com/package/create-fs-cache (repo https://github.com/neokeld/create-fs-cache)
@webmaster128 has published a pull request to the original lib loader-fs-cache and i hope it will be merged soon by @viankakrisna
But if it is needed i will maintain my fork.

@neokeld
Copy link
Contributor

neokeld commented Mar 22, 2020

@viankakrisna has published a new version (1.0.3) of loader-fs-cache with the fix.

neokeld added a commit to neokeld/eslint-loader that referenced this issue Mar 22, 2020
Fix webpack-contrib#316 updating loader-fs-cache min version.
The new version of loader-fs-cache has support for a new version of minimist which has not the prototype pollution vuln (CVE-2020-7598).
@vilbergs
Copy link

vilbergs commented Mar 23, 2020

I forked to see if this was an easy fix. Seems that the vulnerability is bubbling up from standard-version.

I assume there's no direct action to be taken here.

neokeld added a commit to neokeld/eslint-loader that referenced this issue Mar 23, 2020
@neokeld
Copy link
Contributor

neokeld commented Mar 23, 2020

Indeed it is also coming from standard-version,

|---------------|--------------------------------------------------------------|
| Low           | Prototype Pollution                                          |
|---------------|--------------------------------------------------------------|
| Package       | minimist                                                     |
|---------------|--------------------------------------------------------------|
| Patched in    | >=0.2.1 <1.0.0 || >=1.2.3                                    |
|---------------|--------------------------------------------------------------|
| Dependency of | standard-version [dev]                                       |
|---------------|--------------------------------------------------------------|
| Path          | standard-version > conventional-changelog >                  |
|               | conventional-changelog-core > conventional-changelog-writer  |
|               | > handlebars > optimist > minimist                           |
|---------------|--------------------------------------------------------------|
| More info     | https://npmjs.com/advisories/1179                            |
|---------------|--------------------------------------------------------------|

There is an ongoing pull request on handlebars to fix this vuln : handlebars-lang/handlebars.js#1662

ricardogobbosouza pushed a commit that referenced this issue Mar 30, 2020
* Fix #316 updating loader-fs-cache min version

Fix #316 updating loader-fs-cache min version.
The new version of loader-fs-cache has support for a new version of minimist which has not the prototype pollution vuln (CVE-2020-7598).

* fix: fix #316 update loader-fs-cache also in package-lock
@OZZlE
Copy link
Author

OZZlE commented Apr 1, 2020

It loks like @neokeld committed a fix but I don't see any new release version.. I took the work time to revisit this again now that I saw it was 'fixed' but it doesn't seem to be.. I installed latest..

@ricardogobbosouza
Copy link
Collaborator

@OZZlE I haven't launched yet

@ricardogobbosouza
Copy link
Collaborator

@OZZlE v3.0.4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants