Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

docs: formatting #297

Merged
merged 3 commits into from Sep 25, 2019
Merged

docs: formatting #297

merged 3 commits into from Sep 25, 2019

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Sep 25, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@alexander-akait
Copy link
Member

Feel free to merge when CI will be green

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #297   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         134    134           
  Branches       28     28           
=====================================
  Hits          134    134

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360e69c...d745080. Read the comment docs.

@ricardogobbosouza
Copy link
Collaborator Author

@evilebottnawi I need you to approve to merge
Merging can be performed automatically with 1 approving review.

@ricardogobbosouza
Copy link
Collaborator Author

Bug on azure pipelines 😞
Stopped on MacOS

@ricardogobbosouza
Copy link
Collaborator Author

@evilebottnawi
I can't push to branch master
#294 (comment)

@alexander-akait
Copy link
Member

@ricardogobbosouza try again

@ricardogobbosouza ricardogobbosouza merged commit c6b7c12 into master Sep 25, 2019
@ricardogobbosouza ricardogobbosouza deleted the update-docs branch September 25, 2019 19:57
@ricardogobbosouza
Copy link
Collaborator Author

@evilebottnawi

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "licence/cla" is expected. At least 1 approving review is required by reviewers with write access.
To github.com:webpack-contrib/eslint-loader.git

  • [new tag] v3.0.1 -> v3.0.1
    ! [remote rejected] master -> master (protected branch hook declined)
    error: failed to push some refs to 'git@github.com:webpack-contrib/eslint-loader.git'

@alexander-akait
Copy link
Member

alexander-akait commented Sep 25, 2019

@ricardogobbosouza problem still exists? Looks all fine https://github.com/webpack-contrib/eslint-loader/commits/master

@ricardogobbosouza
Copy link
Collaborator Author

@evilebottnawi yes

@alexander-akait
Copy link
Member

@ricardogobbosouza what is email on commit? CLA failed when email is invalid for commit

@alexander-akait
Copy link
Member

@ricardogobbosouza try again

@ricardogobbosouza
Copy link
Collaborator Author

@evilebottnawi sorry, its works

@alexander-akait
Copy link
Member

Great! Feel free to ping me if you need help with something, you can invite other people as member if you need help from other developers (you have permission), anyway before big release will be great if somebody review your code (like me or other developers from webpack/webpack-contrib)

@ricardogobbosouza
Copy link
Collaborator Author

Ok, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants