[Feature request] Support Eslint version 6

[jimblue]

Hi,

ESlint 6 have been release, could you please add it to the peerDependencies, thank you.

eslint-loader/package.json

Line 19 in 02c1e76

"eslint": ">=1.6.0 <6.0.0",

[milewski]

It looks like this loader breaks with eslint 6...

[jimblue]

Indeed I've just try. Renaming this issue to support ESlint 6

[graue]

This would be fixed by #275, but there's a need to update the CI configuration so it doesn't attempt to test with ESLint 6 on Node 6, since ESLint has dropped support for Node 6.

[platinumazure]

Hi everyone, I'm from ESLint.

Instead of doing a direct require to a formatter path, I would recommend CLIEngine#getFormatter (if you have a CLIEngine instance) or CLIEngine.getFormatter (static function you can use if you don't have an instance).

Requiring the path directly is not part of the public API and could change any time, even in patch releases. The two CLIEngine options are in the public API and won't change except in a major release (and then, only when absolutely needed and we can't deprecate).

Good luck! Please stop by our Gitter chat if you need help.

[vesper8]

related to vuejs/eslint-plugin-vue#916

[rwieruch]

related eslint/eslint#11910

Breaks with ESLint 6.0.1. Works with 5.16.0.

[Mintonne]

Similar issue

Module build failed (from ./node_modules/eslint-loader/index.js):
Error: Failed to load plugin 'import' declared in '.eslintrc.js » @vue/eslint-config-standard » C:\Users\Anon\Desktop\xxxx\node_modules\eslint-config-standard\index.js': Cannot find module 'eslint/lib/util/source-code'

Works perfectly with 5.16.0

[ricardogobbosouza]

Hi @jimblue
Resolved #275
Waiting a new version

[jimblue]

Sounds good 😄
Waiting the new release to test it and close this issue.

[ahmadalfy]

@jimblue anything we can do to accelerate this process?

[saveman71]

@ahmadalfy I don't think @jimblue can do anything since he's just the issue reporter 😅

I guess tagging @MoOx who seem to be the one releasing the package on npm can help.

[MoOx]

See #264

[saveman71]

Sorry I missed that, didn't mean anything rude! Thanks for taking the time to reply.

[MoOx]

Don't worry, I just reopened this issue as it's still relevant as you can see.

[alexander-akait]

Published https://www.npmjs.com/package/eslint-loader?activeTab=versions