From 8cb02a654fe50824a27b8a6457fbf1fdfd56076f Mon Sep 17 00:00:00 2001 From: Ricardo Gobbo de Souza Date: Thu, 4 Jul 2019 12:04:59 -0300 Subject: [PATCH] docs: update `gotchas` (#284) --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 25d1855..ad29281 100644 --- a/README.md +++ b/README.md @@ -298,7 +298,11 @@ module.exports = { ## Gotchas -### NoErrorsPlugin +### NoEmitOnErrorsPlugin for `webpack >= 4` + +`NoEmitOnErrorsPlugin` is now automatically enabled in webpack 4, when mode is either unset, or set to production. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`, except if `emitWarning` enabled. + +### NoErrorsPlugin for `webpack < 4` `NoErrorsPlugin` prevents webpack from outputting anything into a bundle. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`. @@ -316,7 +320,9 @@ See [#129](https://github.com/webpack-contrib/eslint-loader/issues/129). --- ## Changelog + [Changelog](CHANGELOG.md) ## License + [MIT](./LICENSE)