Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loader #956

Merged
merged 6 commits into from Jun 10, 2019
Merged

Refactor loader #956

merged 6 commits into from Jun 10, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

refactor code

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #956 into master will decrease coverage by 0.25%.
The diff coverage is 99.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
- Coverage    98.6%   98.35%   -0.26%     
==========================================
  Files          10       10              
  Lines         431      425       -6     
  Branches      133      127       -6     
==========================================
- Hits          425      418       -7     
- Misses          6        7       +1
Impacted Files Coverage Δ
src/utils.js 99.12% <100%> (-0.29%) ⬇️
src/runtime/getUrl.js 100% <100%> (ø)
src/plugins/postcss-import-parser.js 97.87% <100%> (ø) ⬆️
src/index.js 97.87% <100%> (+0.31%) ⬆️
src/plugins/postcss-url-parser.js 97.67% <100%> (+0.14%) ⬆️
src/plugins/postcss-icss-parser.js 98.33% <97.36%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0672e78...681f98c. Read the comment docs.

@alexander-akait alexander-akait merged commit 49f3ff0 into master Jun 10, 2019
@alexander-akait alexander-akait deleted the refactor-loader branch June 10, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant