Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid the "from" argument must be of type string error #908

Merged
merged 1 commit into from Mar 11, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #906

Use existing tests

Breaking Changes

No, it is more refactor than bugfix

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #908 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   99.24%   99.24%   +<.01%     
==========================================
  Files          10       10              
  Lines         396      397       +1     
  Branches      118      119       +1     
==========================================
+ Hits          393      394       +1     
  Misses          3        3
Impacted Files Coverage Δ
src/utils.js 97.43% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc16c3d...e19392e. Read the comment docs.

@alexander-akait alexander-akait merged commit e5dfd23 into master Mar 11, 2019
@alexander-akait alexander-akait deleted the issue-906 branch March 11, 2019 17:58
@mathportillo
Copy link

Hello,

Can this fix be released?
If not, is there anyway I can access this fix before a official release? Installing this package from a git commit won't work.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError [ERR_INVALID_ARG_TYPE]: The "from" argument must be of type string. Received type undefined
2 participants