Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): trim unquoted import urls #783

Merged

Conversation

joelgallant
Copy link
Contributor

What kind of change does this PR introduce?
Fixes #781

Did you add tests for your changes?
Yep

If relevant, did you update the README?
Nope

Summary
This removes trailing whitespace from unquoted import urls

Does this PR introduce a breaking change?
It shouldn't

@jsf-clabot
Copy link

jsf-clabot commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@joelgallant
Copy link
Contributor Author

I don't think the appveyor failure has anything to do with this PR

@alexander-akait
Copy link
Member

@joelgallant Just for note, already fixed in next #760

@joelgallant
Copy link
Contributor Author

This would still apply to the stable version though yeah?

@alexander-akait
Copy link
Member

@joelgallant yep

@michael-ciniawsky michael-ciniawsky changed the title Trims whitespace in import urls for unquoted imports fix(loader): trim unquoted import urls Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants