Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect the localIdentRegExp option #1349

Merged
merged 2 commits into from Jul 17, 2021
Merged

fix: respect the localIdentRegExp option #1349

merged 2 commits into from Jul 17, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1346

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #1349 (173ba65) into master (9560168) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   98.35%   98.36%   +0.01%     
==========================================
  Files          11       11              
  Lines         975      981       +6     
  Branches      325      327       +2     
==========================================
+ Hits          959      965       +6     
  Misses         13       13              
  Partials        3        3              
Impacted Files Coverage Δ
src/utils.js 97.61% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9560168...173ba65. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option localIdentRegExp doesn't work after upgraded to 6.0.
1 participant