Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve #1290

Merged
merged 1 commit into from Apr 19, 2021
Merged

perf: improve #1290

merged 1 commit into from Apr 19, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

improve perf

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1290 (ae6864b) into master (4f10583) will decrease coverage by 0.05%.
The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   98.25%   98.20%   -0.06%     
==========================================
  Files          11       11              
  Lines         804      835      +31     
  Branches      271      279       +8     
==========================================
+ Hits          790      820      +30     
  Misses         12       12              
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/utils.js 97.15% <95.45%> (-0.04%) ⬇️
src/plugins/postcss-import-parser.js 100.00% <100.00%> (ø)
src/plugins/postcss-url-parser.js 97.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f10583...ae6864b. Read the comment docs.

@alexander-akait alexander-akait merged commit 911f02d into master Apr 19, 2021
@alexander-akait alexander-akait deleted the perf-improve branch April 19, 2021 13:01
@jayaddison
Copy link

👋 Hi / meow @alexander-akait - I'm the kind of annoying OSS contributor who takes the opportunity to read individual commits and diffs between release versions.

I was wondering if you could add any details about what the performance improvements are in this pull request, and how they're measured (or how you would like performance testing to be improved for your projects, if that's something you're interested in)?

@alexander-akait
Copy link
Member Author

@jayaddison Hello, it is optimization for V8, you can read about it more here postcss/postcss-selector-parser#239

@jayaddison
Copy link

That is a brilliant investigation, thank you for the link @alexander-akait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants