Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash with thread-loader #1281

Merged
merged 1 commit into from Mar 24, 2021
Merged

fix: crash with thread-loader #1281

merged 1 commit into from Mar 24, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1280

Breaking Changes

No

Additional Info

Ideally should be fixed on thread-loader side, but in long term multiple threading will be part of core, so fix is good right now

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1281 (f335480) into master (e194e6b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          11       11           
  Lines         753      754    +1     
  Branches      258      259    +1     
=======================================
+ Hits          749      750    +1     
  Misses          4        4           
Impacted Files Coverage Δ
src/utils.js 98.77% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e194e6b...f335480. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.1.3 got compile error
1 participant