Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escape getLocalIdent #1196

Merged
merged 3 commits into from Sep 24, 2020
Merged

Fix escape getLocalIdent #1196

merged 3 commits into from Sep 24, 2020

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #966

Breaking Changes

Yes. . is replaced in classname

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1196 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          10       10           
  Lines         671      675    +4     
  Branches      214      215    +1     
=======================================
+ Hits          667      671    +4     
  Misses          4        4           
Impacted Files Coverage Δ
src/utils.js 98.70% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd52931...e2905ba. Read the comment docs.

@alexander-akait alexander-akait merged commit d779eb1 into master Sep 24, 2020
@alexander-akait alexander-akait deleted the fix-escape-getLocalIdent branch September 24, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

values in selectors aren't escaped properly.
2 participants