refactor: code #1059
Merged
refactor: code #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 97.53% 97.17% -0.37%
==========================================
Files 10 10
Lines 447 460 +13
Branches 148 153 +5
==========================================
+ Hits 436 447 +11
- Misses 10 12 +2
Partials 1 1
Continue to review full report at Codecov.
|
jamesgeorge007
requested changes
Mar 25, 2020
src/utils.js
Outdated
Comment on lines
181
to
182
| function getPreRequester(loaderContext) { | ||
| const { loaders, loaderIndex } = loaderContext; |
There was a problem hiding this comment.
Suggested change
| function getPreRequester(loaderContext) { | |
| const { loaders, loaderIndex } = loaderContext; | |
| function getPreRequester({ loaders, loaderIndex }) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Just refactor, step #2
Breaking Changes
No
Additional Info
No