Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code #1017

Merged
merged 1 commit into from Dec 12, 2019
Merged

refactor: code #1017

merged 1 commit into from Dec 12, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

just refactor

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1017 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   99.56%   99.56%   -0.01%     
==========================================
  Files          10       10              
  Lines         463      462       -1     
  Branches      127      131       +4     
==========================================
- Hits          461      460       -1     
  Misses          2        2
Impacted Files Coverage Δ
src/utils.js 99.42% <100%> (+0.03%) ⬆️
src/plugins/postcss-import-parser.js 100% <100%> (ø) ⬆️
src/plugins/postcss-icss-parser.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/plugins/postcss-url-parser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80c39f...bd40f5c. Read the comment docs.

@alexander-akait alexander-akait merged commit 3b12c87 into master Dec 12, 2019
@alexander-akait alexander-akait deleted the refactor-code branch December 12, 2019 14:37
@tagspace
Copy link

hi @evilebottnawi. You've introduced code that uses the spread operator for javascript objects. This is a relatively new feature in javascript, and unfortunately broke our build. Could it be that a change like this should be marked as a minor release, rather than a patch?

@alexander-akait
Copy link
Member Author

@tagspace no, spread operator supported since node@8 and minimum supported version is 8 (you can look at this in package.json)

} else {
// eslint-disable-next-line no-param-reassign
accumulator[normalizedUrl] = {
...accumulator[normalizedUrl],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi this is a relatively new feature in javascript. Introducing this broke our webpack build. Any chance you could use Object.assign(...) instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants