globOptions.ignore not work expected #689

takeTrace · 2022-05-06T10:09:10Z

Bug report

When I use Copy Plugin follow README, it does not work like README said.
And I check issues, after use someone's method, it work, but not work well in sometimes;

Actual Behavior

I use Copy Plugin to copy dir public in my project root dir to webpack output path's dir public,
And I follow the config in README's globOptions descriptionn

new CopyWebpackPlugin({
			patterns: [
				{
					from: "public/**/*",
					globOptions: {
						ignore: [
							"**/.DS_Store",
							"**/index.html",
							"**/asdasd.md",
						],
					},
				},
			],
		})

it doesn't work at all. plugin will copy all the files in public;

and after search I found here ignoring-files in Readme.

new CopyWebpackPlugin({
			patterns: [
				{
					from: path.posix.join(
						path.resolve(__dirname, "public").replace(/\\/g, "/"), "**/*"),
					globOptions: {
						ignore: [
							"**/.DS_Store",
							"**/index.html",
							"**/asdasd.md",
						],
					},
				},
			],
		})

but it doesn't work, still copy all files.

and I found something in issues, try #498 said that I add path.posix function to ignore property, it work, but only work on one file...
if I specific more than one file use path.posix, it throw error

new CopyWebpackPlugin({
			patterns: [
				{
					from: "public/**/*",
					globOptions: {
						ignore: [
							"**/.DS_Store",
							path.posix.join(__dirname, "public/index.html"),
							// path.posix.join(__dirname, "public/asdasd.md"), //if open this. will throw following error 
							// `ERROR in unable to locate '/project-root-dir/public/**/*' glob`
						],
					},
				},
			],
		}),

Expected Behavior

It should ignore public/index.html and public/asdasd.md files when copy to webpack output folder.

How Do We Reproduce?

I create a demo repo.
just run pnpm install && pnpm run build OR npm install && npm run build.

Please paste the results of `npx webpack-cli info` here, and mention other relevant information

System:
OS: macOS 12.3.1
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 38.72 MB / 16.00 GB
Binaries:
Node: 18.1.0 - ~/.nvs/default/bin/node
Yarn: 1.22.18 - /usr/local/bin/yarn
npm: 8.8.0 - ~/.nvs/default/bin/npm
Browsers:
Chrome: 100.0.4896.127
Firefox: 100.0
Safari: 15.4
Packages:
copy-webpack-plugin: ^10.2.4 => 10.2.4
webpack: ^5.72.0 => 5.72.0
webpack-cli: ^4.9.2 => 4.9.2

The text was updated successfully, but these errors were encountered:

alexander-akait · 2022-05-06T12:50:51Z

Sorry, problem is not in the plugin, all options from globOptions passed to fast-glob, so if something is not ignored, it means fast-glob is not ignore it

ruokid · 2022-07-05T04:05:25Z

same issue

copy-webpack-plugin @5.x

new CopyPlugin(
  [
    {
      from: 'public',
      to: '/XXX/dist',
      toType: 'dir',
      ignore: [
        '.DS_Store',
        {
          glob: 'index.html',
          matchBase: false
        }
      ]
    }
  ]
)

copy-webpack-plugin @11.x (ignore option not working)

new CopyWebpackPlugin({
  patterns: [
    {
      from: 'public',
      to: /XXX/dist,
      toType: 'dir',
      globOptions: {
        ignore: [ '.DS_Store', 'index.html' ]
      }
    }
  ]
})

alexander-akait · 2022-07-05T04:09:44Z

Please use **/.DS_Store for nested, docs here https://github.com/mrmlnc/fast-glob#ignore

ruokid · 2022-07-06T07:40:28Z

hi @alexander-akait

when i use it to build

new CopyWebpackPlugin({
  patterns: [
    {
      from: 'public',
      to: /XXX/dist,
      toType: 'dir',
      globOptions: {
        ignore: [ 'index.html' ]
      }
    }
  ]
}),
new HtmlWebpackPlugin({
  filename: 'index.html',
  template: 'public/index.html',
  title: projectName
})

I got

ERROR in Conflict: Multiple assets emit different content to the same filename index.html

now, if i use this

new CopyWebpackPlugin({
  patterns: [
    {
      from: 'public',
      to: /XXX/dist,
      toType: 'dir',
      globOptions: {
        ignore: [ '**/index.html' ]
      }
    }
  ]
}),
new HtmlWebpackPlugin({
  filename: 'index.html',
  template: 'public/index.html',
  title: projectName
})

i got

ERROR in unable to locate '/XXX/public/**/*' glob

and this is my directory

alexander-akait · 2022-07-06T14:56:03Z

ERROR in Conflict: Multiple assets emit different content to the same filename index.html

It means you have multiple files with different content:

You copy files with the same name in one directory (i.e. dir1/index.html and dir2/index.html => dist/index.html)
You have html-webpack-plugin and copy index.html, the situation the same as above, just html-webpack-plugin creates index.html

ruokid · 2022-07-07T04:18:53Z

yes, so i need to ignore public/index.html, but globOptions.ignore not working

alexander-akait · 2022-07-07T14:46:00Z

Try to experiment, ignore is working, just with some limitations

PachVerb · 2022-07-09T10:15:11Z

yes, so i need to ignore public/index.html, but globOptions.ignore not working

it's work for me. just add globalOptions-ignore [**/*.html],

my webpack.common.js

  new webpack.DefinePlugin({
      BASE_URL: JSON.stringify('/'),
    }),
    new HtmlWebpackPlugin({
      // 指定模板,此插件仍然会创建文件
      title: 'Typescript + Vue',
      template: '/public/index.html', // 如果使用自己的模板需要另外引入favicon图标
      //   favicon: '../public/favicon.ico',
    }),

    new CopyPlugin({
      patterns: [
        {
          from: path.resolve(__dirname, '../public'),
          to: path.resolve(__dirname, '../dist'),
          toType: 'dir',
          globOptions: {
            dot: false, // 允许匹配以 . 开头的文件, 比如 .gitignore
            gitignore: false,
            ignore: ['.DS_Store', '**/index.html'],
          },
        },
      ],
    }),

NOTE: html-webpack-plugin, default Specifying the template will also output the html file to the build directory, should you also specify the final output filename

N-You · 2022-10-11T05:22:10Z

hi @alexander-akait

when i use it to build

new CopyWebpackPlugin({
  patterns: [
    {
      from: 'public',
      to: /XXX/dist,
      toType: 'dir',
      globOptions: {
        ignore: [ 'index.html' ]
      }
    }
  ]
}),
new HtmlWebpackPlugin({
  filename: 'index.html',
  template: 'public/index.html',
  title: projectName
})

I got

ERROR in Conflict: Multiple assets emit different content to the same filename index.html

now, if i use this

new CopyWebpackPlugin({
  patterns: [
    {
      from: 'public',
      to: /XXX/dist,
      toType: 'dir',
      globOptions: {
        ignore: [ '**/index.html' ]
      }
    }
  ]
}),
new HtmlWebpackPlugin({
  filename: 'index.html',
  template: 'public/index.html',
  title: projectName
})

i got

ERROR in unable to locate '/XXX/public/**/*' glob

and this is my directory

I had the same problem

alexander-akait · 2022-10-11T11:45:05Z

It means globby can't find directory

wkz2003 · 2023-02-20T17:24:51Z

yes, so i need to ignore public/index.html, but globOptions.ignore not working

it's work for me. just add globalOptions-ignore [**/*.html],

my webpack.common.js

  new webpack.DefinePlugin({
      BASE_URL: JSON.stringify('/'),
    }),
    new HtmlWebpackPlugin({
      // 指定模板,此插件仍然会创建文件
      title: 'Typescript + Vue',
      template: '/public/index.html', // 如果使用自己的模板需要另外引入favicon图标
      //   favicon: '../public/favicon.ico',
    }),

    new CopyPlugin({
      patterns: [
        {
          from: path.resolve(__dirname, '../public'),
          to: path.resolve(__dirname, '../dist'),
          toType: 'dir',
          globOptions: {
            dot: false, // 允许匹配以 . 开头的文件, 比如 .gitignore
            gitignore: false,
            ignore: ['.DS_Store', '**/index.html'],
          },
        },
      ],
    }),

NOTE: html-webpack-plugin, default Specifying the template will also output the html file to the build directory, should you also specify the final output filename

兄弟我复制你的发现也不报错了，啥原理啊这是，我听着有点迷糊

wkz2003 · 2023-02-20T17:31:50Z

yes, so i need to ignore public/index.html, but globOptions.ignore not working

it's work for me. just add globalOptions-ignore [**/*.html],

my webpack.common.js

  new webpack.DefinePlugin({
      BASE_URL: JSON.stringify('/'),
    }),
    new HtmlWebpackPlugin({
      // 指定模板,此插件仍然会创建文件
      title: 'Typescript + Vue',
      template: '/public/index.html', // 如果使用自己的模板需要另外引入favicon图标
      //   favicon: '../public/favicon.ico',
    }),

    new CopyPlugin({
      patterns: [
        {
          from: path.resolve(__dirname, '../public'),
          to: path.resolve(__dirname, '../dist'),
          toType: 'dir',
          globOptions: {
            dot: false, // 允许匹配以 . 开头的文件, 比如 .gitignore
            gitignore: false,
            ignore: ['.DS_Store', '**/index.html'],
          },
        },
      ],
    }),

NOTE: html-webpack-plugin, default Specifying the template will also output the html file to the build directory, should you also specify the final output filename

刚看错了，还是报错啊兄弟

rendall · 2023-02-22T08:14:24Z

I'm not sure I completely understand if this will help OP, but I wanted to ignore specific files in the from: directory (in my case, only ./static/index.html and not ./static/**/index.html. For people struggling with this like me, you might consider ditching globOptions and using filter instead. It's a predicate that takes the file's (absolute) path and returns a true or false to be copied or not.

This is how I got it to work:

patterns: [{ from: "./static", filter:(filepath) => {
    const ignorePaths = ['/static/index.html']
    const doCopy = ignorePaths.every(path => !filepath.endsWith(path))
     return doCopy;
} }]

For my case, since I am ignoring one file, a simple return !filePath.endsWith('/static/index.html') would be fine. In this code, you can add your filepath to ignorePaths and it will return false if the (absolute) filepath ends in any of the ignorePaths, true otherwise.

wkz2003 · 2023-02-22T16:29:14Z

I'm not sure I completely understand the OP, but I wanted to ignore specific files in the from: directory (in my case, only ./static/index.html and not ./static/**/index.html. For people struggling with this like me, you might consider ditching globOptions and using filter instead. It's a predicate that takes the file's (absolute) path and returns a true or false, whether you want it to be copied or not.

This is how I got it to work:
patterns: [{ from: "./static", filter:(filepath) => {
    const ignorePaths = ['/static/index.html']
    const doCopy = ignorePaths.every(path => !filepath.endsWith(path))
     return doCopy;
} }]
For my case, since I am ignoring one file, a simple return !filePath.endsWith('/static/index.html') would be fine. In this code, you can add your filepath to ignorePaths and it will return false if the (absolute) filepath ends in any of the ignorePaths, true otherwise.

oh! It's a good solution.The only shortcoming is I can't use cases like 'public/**.html',but I think I can use regex to fix that

rendall · 2023-02-22T18:56:34Z

Definitely! Something like

return /public\/.*\.html$/.test(filepath)

realmxu · 2023-03-22T16:40:27Z

      ignore: ['.DS_Store', '**/index.html'],

globalOptions.ignore seems only work on alone '**/index.html' but i can use fliter option hahaha.

Sober-1 · 2023-03-25T16:59:51Z

hi @alexander-akait ,I encountered the same problem as above.
The plug-in version I use is 11.0.0.

I tried to copy the contents of the public folder under the root directory to the webpack packaged folder,
And ignore a.js, b.js, and index.html.
When I ignore only a.js and index.html, it works normally, but when I ignore b.js at the same time, an error will be reported.

Could you explain the reason? thank you!

alexander-akait · 2023-03-27T15:53:49Z

@Sober-1 hm, can you create reproducible test repo? it should work

Sober-1 · 2023-03-27T15:59:30Z

@alexander-akait
I also did a test on my Mac and the same problem occurred

alexander-akait · 2023-03-27T16:48:33Z

Do you have the public directory? If no (or if it will be created as a part of build) please try https://github.com/webpack-contrib/copy-webpack-plugin#noerroronmissing

Sober-1 · 2023-03-28T02:17:33Z

I used " noErrorOnMissing: true", Now the problem has been solved. thank you

fsjohnhuang · 2023-04-14T06:49:55Z

Change index.html to **/public/index.html would work as expect.

hl662 mentioned this issue Aug 1, 2023

fix ignore path problem imodeljs/create-react-app#106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

globOptions.ignore not work expected #689

globOptions.ignore not work expected #689

takeTrace commented May 6, 2022 •

edited

alexander-akait commented May 6, 2022 •

edited

ruokid commented Jul 5, 2022

alexander-akait commented Jul 5, 2022

ruokid commented Jul 6, 2022 •

edited

alexander-akait commented Jul 6, 2022

ruokid commented Jul 7, 2022

alexander-akait commented Jul 7, 2022

PachVerb commented Jul 9, 2022

N-You commented Oct 11, 2022

alexander-akait commented Oct 11, 2022

wkz2003 commented Feb 20, 2023

wkz2003 commented Feb 20, 2023

rendall commented Feb 22, 2023 •

edited

wkz2003 commented Feb 22, 2023 •

edited

rendall commented Feb 22, 2023

realmxu commented Mar 22, 2023

Sober-1 commented Mar 25, 2023

alexander-akait commented Mar 27, 2023

Sober-1 commented Mar 27, 2023

alexander-akait commented Mar 27, 2023

Sober-1 commented Mar 28, 2023

fsjohnhuang commented Apr 14, 2023 •

edited

globOptions.ignore not work expected #689

globOptions.ignore not work expected #689

Comments

takeTrace commented May 6, 2022 • edited

Bug report

Actual Behavior

Expected Behavior

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information

alexander-akait commented May 6, 2022 • edited

ruokid commented Jul 5, 2022

alexander-akait commented Jul 5, 2022

ruokid commented Jul 6, 2022 • edited

alexander-akait commented Jul 6, 2022

ruokid commented Jul 7, 2022

alexander-akait commented Jul 7, 2022

PachVerb commented Jul 9, 2022

N-You commented Oct 11, 2022

alexander-akait commented Oct 11, 2022

wkz2003 commented Feb 20, 2023

wkz2003 commented Feb 20, 2023

rendall commented Feb 22, 2023 • edited

wkz2003 commented Feb 22, 2023 • edited

rendall commented Feb 22, 2023

realmxu commented Mar 22, 2023

Sober-1 commented Mar 25, 2023

alexander-akait commented Mar 27, 2023

Sober-1 commented Mar 27, 2023

alexander-akait commented Mar 27, 2023

Sober-1 commented Mar 28, 2023

fsjohnhuang commented Apr 14, 2023 • edited

takeTrace commented May 6, 2022 •

edited

Please paste the results of `npx webpack-cli info` here, and mention other relevant information

alexander-akait commented May 6, 2022 •

edited

ruokid commented Jul 6, 2022 •

edited

rendall commented Feb 22, 2023 •

edited

wkz2003 commented Feb 22, 2023 •

edited

fsjohnhuang commented Apr 14, 2023 •

edited