Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop cjs wrapper #654

Merged
merged 1 commit into from Dec 16, 2021
Merged

refactor: drop cjs wrapper #654

merged 1 commit into from Dec 16, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

improve types DX

Breaking Changes

Potentially yes, but we use babel and our code in commonjs format, so we should generate types in the same format

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #654 (54be273) into master (d6a6cdb) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   89.94%   90.17%   +0.22%     
==========================================
  Files           3        2       -1     
  Lines         388      397       +9     
  Branches      119      119              
==========================================
+ Hits          349      358       +9     
  Misses         38       38              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 90.16% <100.00%> (+0.28%) ⬆️
src/utils.js 90.24% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a6cdb...54be273. Read the comment docs.

@alexander-akait alexander-akait merged commit 5901006 into master Dec 16, 2021
@alexander-akait alexander-akait deleted the feat-drop-cjs-wrapper branch December 16, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant