Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update globby #641

Merged
merged 2 commits into from Nov 17, 2021
Merged

chore(deps): update globby #641

merged 2 commits into from Nov 17, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Nov 17, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

update globby, new globby uses ESM, so we use import() to load it, for testing purposes we bundle globby using webpack to commonjs and use jest aliases to load bundled copy, unfortunately import() is broken in Jest, so without it we can't test our code

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #641 (5d9735d) into master (5222a28) will decrease coverage by 0.44%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   93.27%   92.83%   -0.45%     
==========================================
  Files           3        3              
  Lines         372      377       +5     
  Branches      108      109       +1     
==========================================
+ Hits          347      350       +3     
- Misses         25       27       +2     
Impacted Files Coverage Δ
src/index.js 92.92% <60.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5222a28...5d9735d. Read the comment docs.

@alexander-akait alexander-akait merged commit 23a4301 into master Nov 17, 2021
@alexander-akait alexander-akait deleted the chore-update-globby branch November 17, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant