Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #401

Merged
merged 3 commits into from Nov 5, 2019
Merged

Fix typo #401

merged 3 commits into from Nov 5, 2019

Conversation

ream88
Copy link
Contributor

@ream88 ream88 commented Sep 25, 2019 •
edited

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

@jsf-clabot
Copy link

jsf-clabot commented Sep 25, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@3103940). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #401   +/-   ##
=========================================
  Coverage          ?   94.88%           
=========================================
  Files             ?        9           
  Lines             ?      293           
  Branches          ?       78           
=========================================
  Hits              ?      278           
  Misses            ?       14           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3103940...ad5e2ad. Read the comment docs.

alexander-akait
alexander-akait approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-akait
Copy link
Member

Please accept CLA

@ream88
Copy link
Contributor Author

ream88 commented Sep 26, 2019

For what ever reason, I can't sign. Safari complains about [Error] Cannot load script https://github.githubassets.com/assets/github-bootstrap-e79d5d49.js. Failed integrity metadata check. and half of GitHub is not usable!

@alexander-akait
Copy link
Member

@ream88 try to use other problem

@ream88
Copy link
Contributor Author

ream88 commented Sep 26, 2019

done

@alexander-akait
Copy link
Member

Thanks all good!

@alexander-akait alexander-akait merged commit 9146c2a into webpack-contrib:master Nov 5, 2019
@ream88 ream88 deleted the patch-1 branch November 5, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ream88 @jsf-clabot @alexander-akait @evilebottnawi