Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor code refactor #399

Merged

Conversation

jamesgeorge007
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

use includes() to check for existence

Breaking Changes

N/A

Additional Info

N/A

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c546871). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage          ?   94.88%           
=========================================
  Files             ?        9           
  Lines             ?      293           
  Branches          ?       78           
=========================================
  Hits              ?      278           
  Misses            ?       14           
  Partials          ?        1
Impacted Files Coverage Δ
src/preProcessPattern.js 97.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c546871...e96d4c5. Read the comment docs.

@alexander-akait alexander-akait merged commit 3103940 into webpack-contrib:master Nov 5, 2019
@alexander-akait
Copy link
Member

Thanks!

@jamesgeorge007 jamesgeorge007 deleted the feat/refactor branch November 5, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants