Fix broken fragment links #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown generated heading fragments to not contain uppercase letters. It seems Githubs own javascript to handle fragment link clicks knows this and lowercases it on click, the same thing does not happen in webpack.js.org The PR fixes the problem on webpack.js.org as well
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 9 9
Lines 293 293
Branches 78 78
=======================================
Hits 278 278
Misses 14 14
Partials 1 1Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
The markdown generated heading fragments to not contain uppercase letters. It seems Githubs own javascript to handle fragment link clicks knows this and lowercases it on click, the same thing does not happen in webpack.js.org
The PR fixes the problem on webpack.js.org as well