Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor #394

Merged
merged 11 commits into from Jul 26, 2019
Merged

test: refactor #394

merged 11 commits into from Jul 26, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

refactor tests

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait mentioned this pull request Jul 24, 2019
6 tasks
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files           9        9           
  Lines         293      293           
  Branches       78       78           
=======================================
  Hits          278      278           
  Misses         14       14           
  Partials        1        1
Impacted Files Coverage Δ
src/processPattern.js 97.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0c736...a39976e. Read the comment docs.

@alexander-akait alexander-akait force-pushed the test-refactor branch 7 times, most recently from 8db5a89 to 819d900 Compare July 24, 2019 20:13
mistic
mistic previously approved these changes Jul 25, 2019
Copy link

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic self-requested a review July 25, 2019 13:48
mistic
mistic previously approved these changes Jul 25, 2019
@alexander-akait alexander-akait merged commit f848140 into master Jul 26, 2019
@alexander-akait alexander-akait deleted the test-refactor branch July 26, 2019 10:24
Copy link

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants