Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better determinate template in to option #363

Merged
merged 1 commit into from Mar 22, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

template regex changed so we should update fix here too

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files           8        9    +1     
  Lines         286      286           
  Branches       75       75           
=======================================
  Hits          271      271           
  Misses         14       14           
  Partials        1        1
Impacted Files Coverage Δ
src/preProcessPattern.js 97.56% <100%> (-0.03%) ⬇️
src/utils/isTemplateLike.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3946473...45e5e95. Read the comment docs.

@alexander-akait alexander-akait merged commit 52f8be6 into master Mar 22, 2019
@alexander-akait alexander-akait deleted the fix-better-determinate-template-in-to branch March 22, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant