Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallback to transform cache directory #361

Merged
merged 1 commit into from Mar 22, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

From docs:

findCacheDir([options])
Finds the cache directory using the supplied options. The algorithm tries to find a package.json file, searching every parent directory of the cwd specified (or implied from other options). It returns a string containing the absolute path to the cache directory, or null if package.json was never found.

Breaking Changes

No

Additional Info

hard to tests this

@alexander-akait alexander-akait force-pushed the fix-add-fallback-cache-directory branch from e8faf57 to cbd4e19 Compare March 22, 2019 10:16
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #361 into master will decrease coverage by 0.31%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   95.07%   94.75%   -0.32%     
==========================================
  Files           8        8              
  Lines         284      286       +2     
  Branches       73       75       +2     
==========================================
+ Hits          270      271       +1     
- Misses         13       14       +1     
  Partials        1        1
Impacted Files Coverage Δ
src/postProcessPattern.js 89.18% <66.66%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf4306...cbd4e19. Read the comment docs.

@alexander-akait alexander-akait merged commit 05963eb into master Mar 22, 2019
@alexander-akait alexander-akait deleted the fix-add-fallback-cache-directory branch March 22, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant