Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch on windows #359

Merged
merged 1 commit into from Mar 22, 2019
Merged

fix: watch on windows #359

merged 1 commit into from Mar 22, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #347

Breaking Changes

No

Additional Info

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #359 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   95.03%   95.07%   +0.03%     
==========================================
  Files           8        8              
  Lines         282      284       +2     
  Branches       70       73       +3     
==========================================
+ Hits          268      270       +2     
  Misses         13       13              
  Partials        1        1
Impacted Files Coverage Δ
src/processPattern.js 97.91% <ø> (-0.09%) ⬇️
src/postProcessPattern.js 90.27% <100%> (+0.13%) ⬆️
src/preProcessPattern.js 97.59% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fc34e...0e9f0ae. Read the comment docs.

@alexander-akait alexander-akait force-pushed the fix-watch-on-windows branch 3 times, most recently from a4721f0 to afbeeba Compare March 21, 2019 16:19
@gewisser
Copy link

I confirm. The problem has been fixed.

Copy link

@gewisser gewisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я подтверждаю. Проблема была исправлена.

@alexander-akait alexander-akait merged commit eaf4306 into master Mar 22, 2019
@alexander-akait alexander-akait deleted the fix-watch-on-windows branch March 22, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch mode not working correctly for certain filetypes
2 participants