Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processPattern): add glob directory context to contextDependencies #290

Merged
merged 1 commit into from Sep 28, 2018
Merged

fix(processPattern): add glob directory context to contextDependencies #290

merged 1 commit into from Sep 28, 2018

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Sep 28, 2018

At the moment when using globs with watch mode and files are added after the initial compilation, they are not copied because the globbed dirname is not added to the context

@jsf-clabot
Copy link

jsf-clabot commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

At the moment when using globs with `watch` mode and files are added after the initial compilation, they are not copied because the globbed `dirname` is not added to the conext
@michael-ciniawsky michael-ciniawsky changed the title fix(processPattern): add glob directory context to contextDependencies fix(processPattern): add glob directory context to contextDependencies Sep 28, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky michael-ciniawsky merged commit 5fa69db into webpack-contrib:master Sep 28, 2018
@michael-ciniawsky michael-ciniawsky added this to the 4.5.3 milestone Sep 28, 2018
@alan-agius4 alan-agius4 deleted the fix_watch_global branch September 29, 2018 05:29
@alan-agius4
Copy link
Contributor Author

Can we get this release please?

@michael-ciniawsky
Copy link
Member

Released in v4.5.3 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 4.5.4 milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants