Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove cjs wrapper and generate types in commonjs format #277

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #273, improve DX for types

Breaking Changes

Potentially yes, but we use babel and our code in commonjs format, so we should generate types in the same format

Additional Info

Now you can use:

import {Rule} from 'compression-webpack-plugin'

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #277 (422ca3f) into master (d863988) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   95.45%   95.65%   +0.19%     
==========================================
  Files           2        1       -1     
  Lines         110      115       +5     
  Branches       43       43              
==========================================
+ Hits          105      110       +5     
  Misses          5        5              
Impacted Files Coverage Δ
src/index.js 95.65% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d863988...422ca3f. Read the comment docs.

@alexander-akait alexander-akait merged commit 8664d36 into master Dec 16, 2021
@alexander-akait alexander-akait deleted the feat-improve-types branch December 16, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[types] Failed to import new types
1 participant