-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: Introduce emulation section, move reshape examples there #598
Open
inexorabletash
wants to merge
35
commits into
webmachinelearning:main
Choose a base branch
from
inexorabletash:content-emulation-decomposition
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Content: Introduce emulation section, move reshape examples there #598
inexorabletash
wants to merge
35
commits into
webmachinelearning:main
from
inexorabletash:content-emulation-decomposition
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in webmachinelearning#551, move the squeeze, unsqueeze, and flatten examples from the reshape definition into a dedicated section. Fixes webmachinelearning#551
Notes:
I don't feel strongly about any of this, it just seemed an easy issue to resolve... |
Makes sense to me. |
@huningxin - can you take a look? Maybe we should merge as-is or with minor tweaks, rather than trying to "boil the ocean" with other spec structure changes? I'm happy to incorporate any suggested changes, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #551, move the squeeze, unsqueeze, and flatten examples from the reshape definition into a dedicated section.
Fixes #551
Preview | Diff