Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Introduce emulation section, move reshape examples there #598

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

inexorabletash
Copy link
Contributor

@inexorabletash inexorabletash commented Mar 8, 2024

Per discussion in #551, move the squeeze, unsqueeze, and flatten examples from the reshape definition into a dedicated section.

Fixes #551


Preview | Diff

Per discussion in webmachinelearning#551, move the squeeze, unsqueeze, and flatten
examples from the reshape definition into a dedicated section.

Fixes webmachinelearning#551
@inexorabletash
Copy link
Contributor Author

Notes:

  • The Appendices - MLOperandDataType and ArrayBufferView compatibility section is normative but now follows two non-normative sections. Can we rename and move it up?
  • This PR only tackles part of the discussion in Deprecated squeeze with emulation path is missing its own section #551 namely moving squeeze (etc) out of reshape. It doesn't move any example decompositions out. If we want to do that, here's an idea
    • Give the new "Operator Emulation" section two subsections: "Emulation" (what's there now) and "Decomposition"
    • Move the 23 "generically emulated" blocks into "decomposition". Reword the preambles to be "The behavior of the hardSwish operation..."
    • Leave non-normative links in a standard format, e.g. "The behavior of this operation can be generically emulated." (which links to the emulation)
    • I am worried about bloating the Table of Contents with the decompositions, though, so I'd propose we leave those out.

I don't feel strongly about any of this, it just seemed an easy issue to resolve...

@zolkis
Copy link
Collaborator

zolkis commented Mar 9, 2024

Makes sense to me.

@inexorabletash inexorabletash marked this pull request as ready for review May 7, 2024 17:50
@inexorabletash
Copy link
Contributor Author

@huningxin - can you take a look? Maybe we should merge as-is or with minor tweaks, rather than trying to "boil the ocean" with other spec structure changes? I'm happy to incorporate any suggested changes, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated squeeze with emulation path is missing its own section
2 participants