Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web platform tests for input validation steps #545

Open
huningxin opened this issue Jan 31, 2024 · 5 comments
Open

Implement web platform tests for input validation steps #545

huningxin opened this issue Jan 31, 2024 · 5 comments
Assignees
Labels

Comments

@huningxin
Copy link
Contributor

The current WebNN web platform tests mainly focus on operator compute result (https://github.com/web-platform-tests/wpt/tree/master/webnn). There is a lack of test cases for input validation steps.

As @reillyeon mentioned in Chromium CL-5231640 for lstm,

it's important that we have a comprehensive test suite for the WebNN API which can be shared between backends in Chromium and with other browser vendors.

For these tests in particular, they are exercising input validation steps that are part of the specification and I feel that they are more appropriately expressed as web platform tests.

/cc @BruceDai

@huningxin
Copy link
Contributor Author

@a-sully , I don't think this requires the spec change. I understand w-p-t is one deliverable of this WG. @anssiko , please correct me if I am wrong.

@anssiko
Copy link
Member

anssiko commented Jan 31, 2024

That's correct. While test contributions go to the https://github.com/web-platform-tests/wpt repo we have used this WebNN spec repo to discuss non-trivial issues related to testing this API to guide test authors. These issues should be triaged with a testing label. The wpt repo is huge so any issues opened against it will get lost easily.

The relevant section in this WG's charter is Other Deliverables that says:

Test suite and implementation report for the specification;

@BruceDai
Copy link
Contributor

BruceDai commented Feb 1, 2024

I will take it and report status later.
@anssiko Please assign it to me, thanks

@BruceDai
Copy link
Contributor

BruceDai commented Feb 6, 2024

I'm working to add validation tests on web-platform-tests/wpt#44416.

@inexorabletash
Copy link
Contributor

That PR landed - is there more work needed or can this be closed out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants