Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM packages without repository urls #2052

Open
rhazarian opened this issue Feb 10, 2024 · 5 comments
Open

NPM packages without repository urls #2052

rhazarian opened this issue Feb 10, 2024 · 5 comments

Comments

@rhazarian
Copy link

Hello!

I have another dependency of graphiql that doesn't contain a repository url in its package configuration: https://www.npmjs.com/package/@motionone/dom. The version of @motionone/dom that is needed by the graphiql version I'm currently trying to deploy is 10.12.0. It seems that here is their original repository: https://github.com/motiondivision/motionone/tree/main/packages/dom. The expected arifactId is motionone__dom.

Do you think it would be possible to modify WebJars deployment mechanism so it could grab the files directly from NPM? If it's possible, I believe it would cover all of the possible cases and free you from these manual deployment requests. Honestly, I feel bad for bothering you already :), and I'm afraid that this may not be the last NPM package without a repo url that is present in this huge dependency graph. I encounter a lot of popular NPM packages without repository urls specified.

@jamesward
Copy link
Member

Yeah, this is a pain. Back story is that we used to deploy via Bintray and they required a source repo. But Maven Central doesn't have that requirement so we could remove the requirement. It'll just take some work to do that. Until then it isn't hard to manually deploy these repos. I've deployed this:

GroupID = org.webjars.npm
ArtifactID = motionone__dom
Version = 10.12.0

I'll keep this issue open as a reminder to remove the requirement.

@rhazarian
Copy link
Author

Makes sense, thanks for the explanation!

It seems that there are some more libraries from the same 'set' that are needed. @motionone/animation (https://www.npmjs.com/package/@motionone/animation), @motionone/generators (https://www.npmjs.com/package/@motionone/generators), @motionone/types (https://www.npmjs.com/package/@motionone/types), @motionone/utils (https://www.npmjs.com/package/@motionone/utils). Their sources are located here: https://github.com/motiondivision/motionone/tree/main/packages. The needed version is 10.12.0.

Thank you for your help, I really hope that we are on the finish line! :)

@jamesward
Copy link
Member

Those have all been deployed and should be in Maven Central shortly.

@rhazarian
Copy link
Author

Apparently, I've skipped one of them :(. There is also @motionone/easing (https://www.npmjs.com/package/@motionone/easing). Similarly, the required version is 10.12.0 - it's a dependency of the previously deployed @motionone/animation.

@jamesward
Copy link
Member

No problem at all! That has been deployed:

GroupID = org.webjars.npm
ArtifactID = motionone__easing
Version = 10.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants