Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published 5.15.2 seems corrupt #212

Open
Peksa opened this issue Apr 17, 2024 · 13 comments
Open

Published 5.15.2 seems corrupt #212

Peksa opened this issue Apr 17, 2024 · 13 comments

Comments

@Peksa
Copy link

Peksa commented Apr 17, 2024

Compared to 5.15.1, paths have changed, and it contains lots of unrelated files:

https://www.webjars.org/listfiles/org.webjars/swagger-ui/5.15.1
https://www.webjars.org/listfiles/org.webjars/swagger-ui/5.15.2

@jamesward
Copy link
Member

Looks like something went wrong with the new way to deploy these: webjars/webjars#2065

I'll investigate.

@jamesward
Copy link
Member

I have a fix that should be deployed soon:
webjars/webjars@3f60ab9

Once deployed I'll try to recreate the broken 5.15.2 release (but it will have to be 5.15.2-1 since Maven Central artifacts are immutable.

@jamesward
Copy link
Member

Ok, 5.15.2-1 has been released and looks better. It will take about an hour to get to Maven Central. Let me know how it goes and sorry about the issue. My tests were insufficient and that has been addressed.

@hboutemy
Copy link
Contributor

no Git commit nor Git tag here https://github.com/webjars/swagger-ui/tags

something remains weird

@jamesward
Copy link
Member

The new user deployable WebJars no longer use git repos. So that part is expected.

@hboutemy
Copy link
Contributor

ok, I see: looks reasonable given how it's largely a copy/paste

question: is there a way to rebuild and check reproducible builds with the new approach?
I'm trying to continue https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/webjars/swagger-ui/README.md

@jamesward
Copy link
Member

Since there isn't a Maven build for the new user deployable Classic WebJars, I don't know how we'd check for build reproducibility.

@hboutemy
Copy link
Contributor

no problem if the build is done with another tool: Reproducible Central is more about the distribution to Maven Central repository than the build tool used to create the jars

@jamesward
Copy link
Member

I'm not totally sure what I need to do. Any pointers?

@hboutemy
Copy link
Contributor

please just tell me how I can rebuild locally swagger-ui 5.17.0: once I can do it by hand, I'll see how to integrate into the Reproducible Central automation (which won't be the same Git repository, for example, and not the same command line as older releases)

you can see a working rebuild by cloning Reproducible Central repository and running ./rebuild.sh content/org/webjars/swagger-ui/swagger-ui-5.15.1.buildspec for example (requires Linux or Mac)

@vkolomeyko
Copy link

Cross-posting here: swagger-api/swagger-ui#9869
This is about OSGi manifest missing from version 5.15.2.

@jamesward
Copy link
Member

@hboutemy Like with NPM WebJars, there isn't really a build for the new Classic WebJar deployment. webjars.org creates the package (jars, pom, etc) and uploads it to Maven Central. I could add an endpoint on webjars.org that'd create the package and download it, but I don't know if that helps at all.

@vkolomeyko Can you open a new issue for that: https://github.com/webjars/webjars/issues/new/choose

@vkolomeyko
Copy link

@jamesward - I have raised: webjars/webjars#2070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants