Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node from node12 to node16 #132

Merged
merged 1 commit into from Oct 19, 2022
Merged

Conversation

bigearsenal
Copy link
Contributor

No description provided.

@bigearsenal bigearsenal changed the title feat: Bump version to 0.6.0 Update node from node12 to node16 Oct 11, 2022
@d3li0n
Copy link

d3li0n commented Oct 12, 2022

Would be a really helpful release.

@maciejp
Copy link

maciejp commented Oct 12, 2022

Thanks for opening the PR, you beat me to it 😉 I think it might be nice to mention why it's important to do it:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@davereid-pfg davereid-pfg mentioned this pull request Oct 14, 2022
@john-doherty
Copy link

HI @davereid-pfg who else need to approve these changes? Keen to get this live

@davereid-pfg
Copy link

I'm not a maintainer so they would need to approve them.

@sebastiankugler
Copy link
Member

sebastiankugler commented Oct 19, 2022

This is the first of three PRs to update to node 16. It suggests a version number 0.6.0, which I like because I see it as a feature release rather than a bugfix as suggested in #134.

I think it would be good though to update also the version number in package.json as suggested by @sfullerbeckman in #134.

@mpdude mpdude merged commit ea4c593 into webfactory:master Oct 19, 2022
@mpdude
Copy link
Member

mpdude commented Oct 19, 2022

Released 0.6.0. Thank you all for your suggestions and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants