Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools fix user data dir #7189

Closed
wants to merge 2 commits into from
Closed

Devtools fix user data dir #7189

wants to merge 2 commits into from

Conversation

erwinheitzman
Copy link
Member

Proposed changes

Set userDataDir to undefined so it behaves exactly the same as before.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Fixes issue when launching the browser using the devtools protocol as it was lauching it with your local profile instead of the profile that it should be using.

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 27, 2021
@christian-bromann
Copy link
Member

@erwinheitzman there seems to be a TypeScript problem:

Error: packages/devtools/src/launcher.ts(103,9): error TS2454: Variable 'userDataDir' is used before being assigned.

@christian-bromann
Copy link
Member

I went ahead and merged a commit with a fix. Thanks Erwin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants