Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export Test Element #7184

Merged
merged 1 commit into from
Jul 27, 2021
Merged

export Test Element #7184

merged 1 commit into from
Jul 27, 2021

Conversation

yon-cuadrado
Copy link
Contributor

Proposed changes

The objective of this pr is to allow the update of the project https://github.com/webdriverio-community/wdio-cucumberjs-json-reporter. I will use the object Test to create a TestStatsExtended object with new TestStatsExtended(test); after changing the type of TestStatsExtended from interface to class. This change is due to the change in the TestStats object in which a private property was included that doesn't allow to initialize the object using the interface. I intend to create a PR with the update of the of the project. But first I would like to create this one to comment this just in case you are going to fix it in another way.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Jul 27, 2021
@christian-bromann christian-bromann merged commit 95225c4 into webdriverio:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants