From d77a890ca433d4c05faf8eaaf8caaa75e3067cf6 Mon Sep 17 00:00:00 2001 From: Christian Bromann Date: Mon, 21 Mar 2022 15:44:59 +0100 Subject: [PATCH] Fix getSize if prop is 0 (#8136) * fix getSize if prop is 0 * fix test --- packages/webdriverio/src/commands/element/getSize.ts | 2 +- packages/webdriverio/tests/commands/element/getSize.test.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/webdriverio/src/commands/element/getSize.ts b/packages/webdriverio/src/commands/element/getSize.ts index d214fec8f44..ae9851681dc 100644 --- a/packages/webdriverio/src/commands/element/getSize.ts +++ b/packages/webdriverio/src/commands/element/getSize.ts @@ -47,7 +47,7 @@ async function getSize ( rect = await this.getElementSize(this.elementId) as RectReturn } - if (prop && rect[prop]) { + if (prop && typeof rect[prop] === 'number') { return rect[prop] as number } diff --git a/packages/webdriverio/tests/commands/element/getSize.test.ts b/packages/webdriverio/tests/commands/element/getSize.test.ts index 7d043b4df4c..8adcb8c7f07 100644 --- a/packages/webdriverio/tests/commands/element/getSize.test.ts +++ b/packages/webdriverio/tests/commands/element/getSize.test.ts @@ -54,6 +54,8 @@ describe('getSize test', () => { expect(width).toBe(50) const height = await elem.getSize('height') expect(height).toBe(30) + const invalid = await elem.getSize('foobar') + expect(invalid).toEqual({ width: 50, height: 30 }) }) afterEach(() => {