Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.ximalaya.com - video or audio doesn't play #16130

Closed
webcompat-bot opened this issue Mar 22, 2018 · 7 comments
Closed

www.ximalaya.com - video or audio doesn't play #16130

webcompat-bot opened this issue Mar 22, 2018 · 7 comments
Labels
browser-firefox-tablet priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Milestone

Comments

@webcompat-bot
Copy link

URL: http://www.ximalaya.com/14647138/album/6527131/

Browser / Version: Firefox Mobile (Tablet) 61.0
Operating System: Android 6.0.1
Tested Another Browser: Unknown

Problem type: Video or audio doesn't play
Description: audio play but no sound
Steps to Reproduce:
open the page and click any play button
Screenshot Description

From webcompat.com with ❤️

@softvision-oana-arbuzov
Copy link
Member

The issue is indeed reproducible on mobile device.
Note: In order to have the same layout as the attached screenshot, "Request desktop site" was enabled.
screenshot-1521709947715

Affected area:

<a class="player-loading" title="加载中"></a>

Click EV

function(e) {
  var t = $(this),
    n = t.attr("href");
  if (t.is("[mustlogin]") && !r.isLogin()) return E(n), !1;
  if (t.is("[hashlink]")) {
    if (o.isSpecial(t)) return i.path = n, i.pushState(""), !1;
    if (!history.pushState) return;
    if ($(e.target).is("[hashlink-disable]")) {
      e.preventDefault();
      return
    }
    if (!n) return;
    var s = S(n),
      u = t.attr("hashlink"),
      a = t.is("[unencode]"),
      f = i.isToSub(u);
    n = n.replace(s, ""), n = n || "/", n = f && i.hashlink(u) ? i.hashlink(u) : n, i.toPage(n, f, u, a), e.preventDefault();
    return
  }
  if (t.is('[onclick="return false;"]') || n == "javascript:;") return
}

Console:

TypeError: t is undefined[Learn More]
almond.js:328:221325
play/<
http://s1.xmcdn.com/js/almond.js:328:221325
select/<
http://s1.xmcdn.com/js/almond.js:328:182406
error
http://s1.xmcdn.com/js/almond.js:328:181804
error
http://s1.xmcdn.com/js/almond.js:328:138631
j/t.error
http://s1.xmcdn.com/js/almond.js:328:138165
l
http://s1.xmcdn.com/js/almond.js:328:28591
fireWith
http://s1.xmcdn.com/js/almond.js:328:29396
N
http://s1.xmcdn.com/js/almond.js:328:90255
r
http://s1.xmcdn.com/js/almond.js:328:95782

Tested with:
Browser / Version: Firefox Mobile Nightly 61.0a1 (2018-03-21)
Operating System: Samsung Galaxy Tab S3 (Android 7.0) - 1536 x 2048 pixels, 4:3 ratio (~264 ppi density), Google Pixel (Android 8.0.0) - 1080 x 1920 pixels (~441 ppi pixel density)

Moving to Needsdiagnosis for further investigation.

@karlcow
Copy link
Member

karlcow commented Mar 26, 2018

note that this layout didn't create issues to me with Firefox Tablet UA on this URI http://m.ximalaya.com/14647138/album/6527131/

Screenshot Description

So there is a working site. Firefox Nightly WebIDE doesn't let me put a breakpoint on almond.js

Let's see with Chrome.

On Chrome it is checking if it's playable, then plays it.

Screenshot Description

@karlcow
Copy link
Member

karlcow commented Mar 26, 2018

Opened this issue for being unable to open a breakpoint on Firefox devtools with this site.
firefox-devtools/debugger#5782

@karlcow
Copy link
Member

karlcow commented Mar 26, 2018

So this is working in Firefox desktop even with touch events on macos. I can reproduce on Firefox mobile with request desktop site, but being unable to set a breakpoint it is a bit hard to investigate for now.

@reinhart1010
Copy link

Tried playing a song in Firefox 59 (Ubuntu 16.04) and it's a M4A file with AAC codec
image

AAC is currently not supported in Firefox, unless if contained in an MP4 video file (see MDN page). This could be another cause of the problem.

@miketaylr miketaylr added the severity-important A non-core broken piece of functionality, not behaving the way you would expect. label Oct 26, 2018
@karlcow
Copy link
Member

karlcow commented Jan 25, 2019

tested again today and everything seems to be working both on desktop and mobile.

@karlcow karlcow closed this as completed Jan 25, 2019
@karlcow karlcow modified the milestones: needsdiagnosis, worksforme Jan 25, 2019
@softvision-oana-arbuzov
Copy link
Member

I've also retested and the issue is no longer reproducible. Checked both with "Request desktop site" option enabled and disabled.
image

Tested with:
Browser / Version: Firefox Nightly 67.0a1 (2019--02-10)
Operating System: Samsung Galaxy Tab S3 (Android 8) - 1536 x 2048 pixels, 4:3 ratio (~264 ppi pixel density)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-tablet priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Projects
None yet
Development

No branches or pull requests

5 participants