Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Sinon with simple class. Full dependency update. Bump to 3.3.4. #115

Merged

Conversation

Hexagon
Copy link
Member

@Hexagon Hexagon commented Sep 28, 2022

  • Sinon is hugely overkill for what it's used for, replaced with a simple stub class (which also removes 6 sub-dependencies).
  • Fix typo in readme
  • Full dependency update
  • Bump to 3.3.4

@codecov-commenter
Copy link

Codecov Report

Base: 92.94% // Head: 92.94% // No change to project coverage 👍

Coverage data is based on head (fb664a8) compared to base (4ab5b91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files          16       16           
  Lines        5984     5984           
=======================================
  Hits         5562     5562           
  Misses        422      422           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesCullum
Copy link
Member

Great input as usual, thanks a lot!

@JamesCullum JamesCullum merged commit 2e07da2 into webauthn-open-source:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants