Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, follow spec, response.userHandle allow null #114

Merged
merged 2 commits into from Sep 25, 2022
Merged

Fix, follow spec, response.userHandle allow null #114

merged 2 commits into from Sep 25, 2022

Conversation

PathToLife
Copy link
Contributor

@PathToLife PathToLife commented Sep 20, 2022

What

Fixes #113

Changes

  • Allow null in userHandle, and fixed regressions
  • Added a test with null in userHandle

@PathToLife PathToLife changed the title userhandle allow null Fix, follow spec, response.userHandle allow null Sep 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Base: 92.90% // Head: 92.94% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (81bfece) compared to base (f6d237d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   92.90%   92.94%   +0.04%     
==========================================
  Files          16       16              
  Lines        5963     5984      +21     
==========================================
+ Hits         5540     5562      +22     
+ Misses        423      422       -1     
Impacted Files Coverage Δ
lib/toolbox.js 89.82% <ø> (+0.23%) ⬆️
lib/parser.js 88.97% <100.00%> (ø)
lib/response.js 97.56% <100.00%> (+0.01%) ⬆️
lib/validator.js 92.29% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesCullum JamesCullum merged commit dc3ffda into webauthn-open-source:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow nullable userHandle as stated in specs
3 participants